Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#110 / 타이머 리팩토링 #111

Merged
merged 2 commits into from
Sep 25, 2023
Merged

#110 / 타이머 리팩토링 #111

merged 2 commits into from
Sep 25, 2023

Conversation

l2zh
Copy link
Member

@l2zh l2zh commented Sep 24, 2023

📌 관련 이슈

📷 screenshot

📝 Work Desciption

  • SharedPreferences 싱글톤으로 관리

📚 Reference 혹은 궁금한 사항들

이전에 타이머 pr에 있어야 됬었는데 충돌 풀다가 날아가서 다시 따로 pr 올립니당...
바로 머지할게요!

@l2zh l2zh requested a review from a team September 24, 2023 17:06
@l2zh l2zh self-assigned this Sep 24, 2023
@l2zh l2zh added refactoring 리팩토링 Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 labels Sep 24, 2023
sub101
sub101 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@sub101 sub101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻👍🏻

@l2zh l2zh merged commit 2fe1dbd into develop Sep 25, 2023
1 check passed
@l2zh l2zh deleted the feature/#110-timer-refactoring branch September 25, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sub101 sub101 sub101 approved these changes

Assignees

@l2zh l2zh

Labels
Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l2zh @sub101